add access permission expiration support #1063
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC: https://app.shortcut.com/globus/story/30787/cli-support-showing-and-setting-expiration-date-field-for-acls
Main changes are the addition of
--expiration-date
toglobus endpoint permission create
andglobus endpoint permission update
and theExpiration Date
output field forglobus endpoint permission show
--permissions
is also no longer a required option forpermission update
so users may only update expiration date.I found a bug in the parsing of principal outputs while working on this caused by the
PrincipalDictFormatter
erroring on response objects being passed. Allowing it to acceptGlobusHTTPResponse
and extract their data seemed like the simplest fix.Also includes fixtures and tests for
permission show
andpermission update
which were previously untested.