Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add access permission expiration support #1063

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaschaer
Copy link
Contributor

SC: https://app.shortcut.com/globus/story/30787/cli-support-showing-and-setting-expiration-date-field-for-acls

Main changes are the addition of --expiration-date to globus endpoint permission create and globus endpoint permission update and the Expiration Date output field for globus endpoint permission show

--permissions is also no longer a required option for permission update so users may only update expiration date.

I found a bug in the parsing of principal outputs while working on this caused by the PrincipalDictFormatter erroring on response objects being passed. Allowing it to accept GlobusHTTPResponse and extract their data seemed like the simplest fix.

Also includes fixtures and tests for permission show and permission update which were previously untested.

@aaschaer aaschaer force-pushed the aaron/permission_expiration branch from edbbccd to 783345c Compare December 20, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant