Add nice names for known resource servers #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
Each resource server listed in our scope requirements map has a nice_server_name attribute associated with it, resulting in the expected mapping auth -> Globus Auth transfer -> Globus Transfer but notably also $timer_service_id -> Globus Timers This enables better output when a command fails the `requires_login` check, as the user is prompted with a known short name rather than a less readable resource_server value. To implement this, the MissingLoginError class now depends upon the scope requirements. But this could be refactored in the future to make the integration between the two more loosely coupled. The names are sorted to provide good guarantees to the testsuite.
sirosen
force-pushed
the
nicer-missing-login-errors
branch
from
e4c40f0 to
ab7a53f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each resource server listed in our scope requirements map has a nice_server_name attribute associated with it, resulting in the expected mapping
but notably also
This enables better output when a command fails the
requires_logincheck, as the user is prompted with a known short name rather than a less readable resource_server value.To implement this, the MissingLoginError class now depends upon the scope requirements. But this could be refactored in the future to make the integration between the two more loosely coupled.