Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce variable scope #1736

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Reduce variable scope #1736

merged 1 commit into from
Dec 3, 2024

Conversation

khk-globus
Copy link
Contributor

Non-functional change; independent of upcoming refactor, so pulling out for clarity.

Type of change

  • Code maintenance/cleanup

Non-functional change; independent of upcoming refactor, so pulling out for
clarity.
@khk-globus khk-globus added no-news-is-good-news This change does not require a news file quick-review Review of this should be quick and easy labels Dec 3, 2024
Copy link
Contributor

@LeiGlobus LeiGlobus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly sure that the mechanic is necessary, but seems safe enough to 👍

@khk-globus khk-globus merged commit 73763ee into main Dec 3, 2024
21 checks passed
@khk-globus khk-globus deleted the reduce_var_scope branch December 3, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-news-is-good-news This change does not require a news file quick-review Review of this should be quick and easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants