Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust cryptography version bounds to be more accurate #486

Merged
merged 1 commit into from
Oct 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.d/20211013_190353_sirosen_fix_crypto_bound.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
* Adjust package metadata for `cryptography` dependency, specifying
`cryptography>=3.3.1` and no upper bound. This is meant to help mitigate
issues in which an older `cryptography` version is installed gets used in
spite of it being incompatible with `pyjwt[crypto]>=2.0` (:pr:`NUMBER`)
11 changes: 10 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,16 @@ def read_readme():
"pyjwt[crypto]>=2.0.0,<3.0.0",
# cryptography 3.4.0 is known-bugged, see:
# https://github.com/pyca/cryptography/issues/5756
"cryptography>=2.0,<3.7,!=3.4.0",
#
# pyjwt requires cryptography>=3.3.1,
# so there's no point in setting a lower bound than that
#
# as of 2021-10-13, we have removed the upper-bound, on the grounds that
# - we actively test on the latest versions
# - cryptography has a strong API stability policy that makes most releases
# non-breaking for our usages
# - other packages /consumers can specify stricter bounds if necessary
"cryptography>=3.3.1,!=3.4.0",
],
extras_require={"dev": DEV_REQUIREMENTS},
keywords=["globus"],
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ extras = dev
deps =
mindeps: requests==2.19.1
mindeps: pyjwt==2.0.0
mindeps: cryptography==2.0
mindeps: cryptography==3.3.1
commands = pytest --cov=src --cov-append --cov-report= {posargs}
depends =
{py36,py37,py38,py39,py36-mindeps}: cov-clean
Expand Down