Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update type of scopes for ClientCredentialsAuthorizer #498

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Conversation

aaschaer
Copy link
Contributor

@aaschaer aaschaer commented Dec 1, 2021

Ran into this while linting client credentials work for the CLI.

The ClientCredentialsAuthorizer was being too strict in the allowed types for scopes since they are just being passed to oauth2_client_credentials_tokens which accepts Optional[Union[str, Iterable[str]]]

@sirosen
Copy link
Member

sirosen commented Dec 1, 2021

This looks very much okay / reasonable to me.

I do want the :pr: link in the changelog. Either as suggested or just amended to

:pr:`498`

I also just noticed that it might be a good idea to double-backtick the union type in the changelog, as

``Union[str, Iterable[str]]``

With the changelog entry minimally edited, I'm happy to merge. We can get a release out shortly.

aaschaer and others added 2 commits December 1, 2021 15:02
Co-authored-by: Stephen Rosen <sirosen@globus.org>
@sirosen sirosen merged commit d83a651 into main Dec 1, 2021
@sirosen sirosen deleted the scopes_type branch December 1, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants