Set a floor for versions of typing_extensions #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`typing_extensions>=4` is required (where typing_extensions is required). This is tested in tox both with `mypy-mindeps` and with `py36-mindeps`. The mypy run is only done in GH Actions to reduce the time spent on this when running `make lint`, as it is unlikely to fail. The `typing` repo has a discussion about capping or not capping the version of `typing_extensions`, but it is not well-resolved. For now, do not apply a cap to the version of `typing_extensions`. We can revisit this if the lack of a cap ever becomes an issue.
rudyardrichter
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typing_extensions>=4is required (where typing_extensions is required).This is tested in tox both with
mypy-mindepsand withpy36-mindeps. The mypy run is only done in GH Actions to reduce the time spent on this when runningmake lint, as it is unlikely to fail.The
typingrepo has a discussion about capping or not capping the version oftyping_extensions, but it is not well-resolved. For now, do not apply a cap to the version oftyping_extensions. We can revisit this if the lack of a cap ever becomes an issue.