Fix pagination behaviors for "next_marker" APIs #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaschaer
reviewed
Feb 18, 2022
Transfer has several APIs which use a nullable `next_marker` field to control pagination. In order to support it, make the following changes: - MarkerPaginator can be given a `marker_key` (defaults to `"marker"`) - MarkerPaginator has a method used to determine if there is another page of results, defaulting to the previously hardcoded has_next_page check - NullableMarkerPaginator(MarkerPaginator) is a new class which alters the has_next_page check to look for a null marker - task_skipped_errors, task_successful_transfers, endpoint_manager_task_successful_transfers, and endpoint_manager_task_skipped_errors now all use a NullableMarkerPaginator and set `marker_key="next_marker"` Add a test for task_skipped_errors specifically, using generated data, to confirm the behavior of the NullableMarkerPaginator with an altered marker_key.
sirosen
force-pushed
the
fix-skipped-errors-pagination
branch
from
e107c85 to
79d4492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transfer has several APIs which use a nullable
next_markerfield to control pagination. In order to support it, make the following changes:marker_key(defaults to"marker")marker_key="next_marker"Add a test for task_skipped_errors specifically, using generated data, to confirm the behavior of the NullableMarkerPaginator with an altered marker_key.