Support python 3.11 #628
Support python 3.11 #628
Conversation
In the changelog, this is called out as "official support" since the code all worked on 3.11 prior to this change. Places touched: - CI testing job on linux (all pythons) - CI testing on windows (latest python only) - CI testing on macos (latest python only) - readthedocs config - pypi classifiers - tox testenvs CI builds should be examined to see what might fail in particular. Local testing under pyenv+tox works, but it's always possible that something will be different in the CI environment.
There was a problem hiding this comment.
Looks good to me!
I see the Windows CI is encountering that most wonderful of all issues, "the shutil.rmtree() that fails for no discernible reason". In the past I "fixed" this by sleeping for .1 seconds in an except clause, at which point trying again would succeed.
That kind of fix is only acceptable in a production environment, though, so you might just try re-running the test or confirming that everything touching that sqlite file has released / closed. 😉
|
I think I'm going to explicitly close the sqlite connections created by the tests. I'm somewhat surprised this hasn't been an issue before now -- we're opening those connections and then trusting GC to clean them up. I might even want to add a |
This is being done to fix the behavior of tests which are leaking resources. The leaked connections can cause tests to fail because there's still a handle on the `.db` file when the temp dir tree is being removed. The method makes it possible to close the connection through a public interface. Rather than adding a context manager interface, for now the testsuite operates by having a fixture which auto-closes SQLiteAdapter instances during test teardown.
|
Whew! That was more of a rewrite to the tests than I expected, but I've just added |
There was a problem hiding this comment.
On Linux (and probably Mac), opening a file for read/write doesn't prevent the file from being deleted. Try this:
# Terminal 1
f = open("abc", "w+")
# Terminal 2
rm abc
# Back to terminal 1
f.write("not backed by the original file anymore? no problem!")
f.close()
# And in terminal 2...
ls abc # finds nothing!
On Windows, though, an open file cannot be deleted so you're depending on garbage collection. Note that PyPy and CPython garbage collect differently, so it's best to explicitly close resources always! 🚪 🥳
|
Yeah, IMO this was a resource leak and we should probably double-check SQLiteAdapter usage sites. It makes me want to add a context manager interface which closes on |
In the changelog, this is called out as "official support" since the code all worked on 3.11 prior to this change.
Places touched:
CI builds should be examined to see what might fail in particular. Local testing under pyenv+tox works, but it's always possible that something will be different in the CI environment.