First version of LocalGlobusConnectServer object #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a start on a local GCS object which looks at the canonical `info.json` file and pulls attributes out of it in a type-safe way. Primarily in order to support testing, the path to the `info.json` file can be set as an argument to the LocalGlobusConnectServer initializer.
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
kurtmckee
requested changes
Nov 9, 2022
Document X|None properties more clearly, and handle bad unicode data in the info.json file. Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
kurtmckee
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a start on a local GCS object which looks at the canonical
info.jsonfile and pulls attributes out of it in a type-safe way.Primarily in order to support testing, the path to the
info.jsonfile can be set as an argument to the LocalGlobusConnectServer initializer.