Yank scope parsing, revert to MutableScope #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After discussion of the ways in which a parse tree cannot accurately represent the meaning of consents and scopes in Auth, we have agreed to pull scope parsing from the upcoming SDK release. The code is remaining in-tree, but no longer provided via documented modules and import paths. The changelog for it has been pulled, replaced by a more modest set of changes to MutableScope, and the docs changes have been further modified to remove any references to scope parsing. Tests continue to exercise the scope tree parsing logic and all of the utility of the Scope class as it was previously introduced.
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
kurtmckee
approved these changes
Nov 22, 2022
I love that phrasing of this. 😹 The cases that you picked out were meant to be reverted to |
Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
sirosen
added a commit
to sirosen/globus-sdk-python
that referenced
this pull request
Nov 22, 2022
This reverts commit adf1001. A manual change is applied to the changelog fragment, in addition to the revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion of the ways in which a parse tree cannot accurately represent the meaning of consents and scopes in Auth, we have agreed to pull scope parsing from the upcoming SDK release. The code is remaining in-tree, but no longer provided via documented modules and import paths. The changelog for it has been pulled, replaced by a more modest set of changes to MutableScope, and the docs changes have been further modified to remove any references to scope parsing.
Tests continue to exercise the scope tree parsing logic and all of the utility of the Scope class as it was previously introduced.