Add last_key arg to endpoint_manager_task_list
#662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue where the TransferClient's `endpoint_manager_task_list` method didn't accept the `last_key` argument sent by the paginator. Signed-off-by: Ada Nikolaidis <ada@globus.org>
ada-globus
requested review from
aaschaer,
derek-globus,
kurtmckee and
sirosen
as code owners
|
I confirmed that the added test case appears to reproduce the issue, and that the proposed fix resolves it. |
kurtmckee
approved these changes
Dec 13, 2022
sirosen
approved these changes
Dec 13, 2022
sirosen
deleted the
an/fix-endpoint-manager-task-list-pagination/sc-20588
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where the TransferClient's
endpoint_manager_task_listmethod didn't accept thelast_keyargument sent by the paginator. Addresses an issue first reported in ticket 359253.Signed-off-by: Ada Nikolaidis ada@globus.org