Revise Example Timer Script #672
Conversation
ada-globus
requested review from
aaschaer,
derek-globus,
kurtmckee and
sirosen
as code owners
| transfer_authorizer = AccessTokenAuthorizer(transfer_token) | ||
| transfer_client = TransferClient(authorizer=transfer_authorizer) | ||
| data = TransferData(transfer_client, GOEP1, GOEP2) | ||
| data.add_item("/share/godata/file1.txt", "/~/file1.txt") |
There was a problem hiding this comment.
I'm seeing this removal, but not the redefinition of data. Do you have an unpushed change for this, perhaps?
I'm guessing that we just want
data = TransferData(source_endpoint=GOEP1, destination_endpoint=GOEP2)
data.add_item(...)There was a problem hiding this comment.
Yep—this was missed in a a copy-paste error when I was moving bits from the script I wrote for the support ticket! 🤦♀️
docs/examples/timer_operations.rst
Outdated
| interval, | ||
| stop_after_n=2, | ||
| name=name, | ||
| scope=str(transfer_action_provider_scope), |
There was a problem hiding this comment.
To clarify, this is passing the string-ized full dependency list.
Is it also valid to pass Timer only this?
scope="https://auth.globus.org/scopes/actions.globus.org/transfer/transfer"
It seems to me that if Timer is going to take its token, do a dependent token grant, and then lookup values in the response, we really ought to be passing it the resource server name ("actions.globus.org", I think?) rather than a scope. Or is there some other purpose here, which requires the full scope be passed?
There was a problem hiding this comment.
Yeah, good call—I had that wrong!
ada-globus
force-pushed
the
an/revise-timer-example
branch
from
845064c to
9279f72
Compare
Changes: - Instantiate the native client - Handle mapped collections - Remove Transfer client from TransferData invocation - Use Transfer action provider in scope tree and revise dependencies Signed-off-by: Ada <ada@globus.org>
ada-globus
force-pushed
the
an/revise-timer-example
branch
from
9279f72 to
9e97fd4
Compare
Signed-off-by: Ada <ada@globus.org>
ada-globus
force-pushed
the
an/revise-timer-example
branch
from
be150ce to
8c3ba30
Compare
Description
Makes some changes to the example Timer script based on discoveries while supporting a user that was running into trouble getting this running: