Widen AuthClient client_id types to include UUID #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
Users are now permitted to pass UUID objects to AuthClient and its subclasses. The UUID is converted to a string on init, but this is more accepting in terms of inputs and matches some usage we have seen in the wild which *probably* works but is not guaranteed. New unit tests simply assert that the UUID values are accepted and converted to str values on init.
sirosen
force-pushed
the
allow-uuid-for-client-id
branch
from
2acdd95 to
61a6ce1
Compare
kurtmckee
approved these changes
Feb 2, 2023
|
The pylint failure is brand new and happens on main, so I'm going to merge in spite of it and then figure out the fix for that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are now permitted to pass UUID objects to AuthClient and its subclasses. The UUID is converted to a string on init, but this is more accepting in terms of inputs and matches some usage we have seen in the wild which probably works but is not guaranteed.
New unit tests simply assert that the UUID values are accepted and converted to str values on init.