include filter rules #712
Merged
include filter rules #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtmckee
requested changes
Mar 22, 2023
kurtmckee
approved these changes
Mar 22, 2023
sirosen
approved these changes
Mar 25, 2023
| @@ -21,4 +21,4 @@ | |||
| tdata.add_filter_rule("*.tgz", type="file") | |||
| # bad values rejected (Literal) | |||
| tdata.add_filter_rule("*.tgz", type="files") # type: ignore[arg-type] | |||
| tdata.add_filter_rule("*.tgz", method="include") # type: ignore[arg-type] | |||
| tdata.add_filter_rule("*.tgz", method="unclude") # type: ignore[arg-type] | |||
There was a problem hiding this comment.
Somehow, this change brings me a great deal of joy.
I know it's just picking some other invalid name, but I can't help but imagine a service supporting "unclude", whatever that means. 😂
|
Transfer support for this was released this morning, I'm looking into the Read the Docs build failure |
Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://app.shortcut.com/globus/story/22583/cli-add-support-for-include-filter-rules
Actual code change is just updating a
Literal, but with a big chunk of doc to explain the new behavior. Opening as a draft as transfer has not yet released.📚 Documentation preview 📚: https://globus-sdk-python--712.org.readthedocs.build/en/712/