Fix the return type annotation for get_identities #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was annotated as GlobusHTTPResponse when it should have been GetIdentitiesResponse. The result is that type checkers could not see that an iterable type was returned. A new mypy test case confirms that the type is now seen correctly, as well as validating several arguments and usages for get_identities.
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
kurtmckee
approved these changes
Apr 14, 2023
aaschaer
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was annotated as GlobusHTTPResponse when it should have been GetIdentitiesResponse. The result is that type checkers could not see that an iterable type was returned.
A new mypy test case confirms that the type is now seen correctly, as well as validating several arguments and usages for get_identities.
📚 Documentation preview 📚: https://globus-sdk-python--716.org.readthedocs.build/en/716/