Implement flows_client.get_run_logs #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derek-globus
requested review from
ada-globus,
kurtmckee,
sirosen and
aaschaer
as code owners
derek-globus
force-pushed
the
implement-flows-get-run-logs-sc-19955
branch
from
7c6109d to
f95e8e2
Compare
aaschaer
reviewed
Apr 26, 2023
ada-globus
approved these changes
Apr 27, 2023
aaschaer
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sc-19955
Important Note
The story requests a method called
get_run_log.I instead implemented a method called
get_run_logsand would advocate that we use this pluralized version.Using the singular version has a strange implication that each individual event is not a discrete "log" but rather the entirety of the list is a "log". I think that will be confusing terminology to expose and would like to change it as we roll this out in a better supported sdk.
What?
Testing
📚 Documentation preview 📚: https://globus-sdk-python--722.org.readthedocs.build/en/722/