Support orderby: Iterable[str] for list_flows
#730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for an iterable of strings to pass this parameter multiple times. The tests for `list_flows` have also been moved to a dedicated module, to keep testing modules more focused on a per-method basis in the suite of functional tests. `orderby` checks for `str` values (passed verbatim), and converts any other value with `list`. This ensures that if a non-sequence iterable is passed, it will be coerced into a type which works well. A new test is added which exercises several different supported types. The `list_flows` documentation now includes example usage (which has been tested out-of-band).
sirosen
requested review from
ada-globus,
derek-globus,
kurtmckee and
aaschaer
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for an iterable of strings to pass this parameter multiple times.
The tests for
list_flowshave also been moved to a dedicated module, to keep testing modules more focused on a per-method basis in the suite of functional tests.orderbychecks forstrvalues (passed verbatim), and converts any other value withlist. This ensures that if a non-sequence iterable is passed, it will be coerced into a type which works well.A new test is added which exercises several different supported types.
The
list_flowsdocumentation now includes example usage (which has been tested out-of-band).📚 Documentation preview 📚: https://globus-sdk-python--730.org.readthedocs.build/en/730/