Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pathlib.Path filenames for token storage adapters #734

Merged
merged 1 commit into from
May 24, 2023

Conversation

kurtmckee
Copy link
Member

@kurtmckee kurtmckee commented May 24, 2023

No new tests were added because mypy linting confirms that the type is coerced to str during assignment to self.filename.


📚 Documentation preview 📚: https://globus-sdk-python--734.org.readthedocs.build/en/734/

Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@sirosen sirosen merged commit 9be8722 into main May 24, 2023
@sirosen sirosen deleted the support-paths-sc-24551 branch May 24, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants