-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transfer client local_user support #736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature looks pretty straightforward from the client side, the Transfer side of it and complexity around it notwithstanding.
If we expect this to take a while, it might be nice to get your new mkdir and rename tests into main
with local_user
removed. I'd fast-track review for that if you want to do the work that way.
I think we could have a very minimal changelog for the SDK which would be suitable no matter what happens. Something like
Several
TransferClient
methods,TransferData
, andDeleteData
now support thelocal_user
,source_local_user
, anddestination_local_user
parameters
But if this is still being discussed, we don't need to rush it.
Co-authored-by: Stephen Rosen <sirosen@globus.org>
This should be good to go now. We still aren't loudly advertising this feature while better Transfer/GCS errors are in progress, but SDK support with a minimal changelog should be fine. We might want to make the CLI options hidden since that's aimed at a broader audience that might need better errors more, but that's a future PR. I also added a change to |
This makes sense to me, and 👍 for including the test and changelog for it. I'm going ahead with the merge. I want to do a quick roundup of other outstanding issues and we can maybe get this out in short order. |
Adds local user selection support to transfer, delete, ls, mkdir, and rename, and _testing support for mkdir and rename
SDK/CLI story: https://app.shortcut.com/globus/story/20504
Corresponding Transfer docs PR: https://github.com/globusonline/docs.globus.org/pull/1322
Opening as draft for a few reasons:
📚 Documentation preview 📚: https://globus-sdk-python--736.org.readthedocs.build/en/736/