Add support for limit and offset to ls #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two parameters to the TransferClient.operation_ls call were missing. The Transfer API documentation has notes on pagination with limit+offset included in the documentation for `limit`. Rather than doing this, pull that same basic content into a `.. note::` directive.
- Remove separate fixture file (generate it inline as part of the test file) and move it to `globus_sdk._testing` style - Move the method test to a dedicated file with parametrized tests
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
kurtmckee
requested changes
Oct 16, 2023
Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
sirosen
force-pushed
the
add-ls-params
branch
from
8afad1b to
4b3f53b
Compare
kurtmckee
approved these changes
Oct 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://globus-sdk-python--868.org.readthedocs.build/en/868/