Add session_required_mfa to some missing auth interfaces #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derek-globus
requested review from
aaschaer,
ada-globus,
kurtmckee and
sirosen
as code owners
derek-globus
force-pushed
the
missing-session-params
branch
from
4674060 to
57ddd9f
Compare
sirosen
reviewed
Jan 26, 2024
sirosen
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
session_required_mfatoglobus_sdk.exc.AuthorizationParameterInfosession_required_policiesto docstring ofglobus_sdk.exc.AuthorizationParameterInfo(attribute already existed)session_required_mfatoAuthLoginClient.oauth2_get_authorize_urlWhy?
Bring auth python objects closer to parity with Auth specification:
Testing
Updated relevant unit tests to supply
session_required_mfavalues.📚 Documentation preview 📚: https://globus-sdk-python--939.org.readthedocs.build/en/939/