Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consent forest sc 30764 #971

Merged
merged 11 commits into from
Apr 19, 2024
Merged

Consent forest sc 30764 #971

merged 11 commits into from
Apr 19, 2024

Conversation

derek-globus
Copy link
Contributor

@derek-globus derek-globus commented Apr 1, 2024 •
edited by github-actions bot
Loading

What?

  • Added consent polling and parsing

Why?

  • Provide a mechanism for clients to locally evaluate their user's auth state to determine whether they will meet dynamic scope requirements across a chain of, potentially asynchronous, service invocation.

📚 Documentation preview 📚: https://globus-sdk-python--971.org.readthedocs.build/en/971/

sirosen
sirosen reviewed Apr 1, 2024
View reviewed changes
Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a full review, but I noticed a couple of small/trivial things when I started reading that should be easy to fix.

src/globus_sdk/services/auth/client/service_client.py Outdated Show resolved Hide resolved
src/globus_sdk/services/auth/client/service_client.py Outdated Show resolved Hide resolved
src/globus_sdk/services/auth/consents.py Outdated Show resolved Hide resolved
sirosen
sirosen requested changes Apr 2, 2024
View reviewed changes
src/globus_sdk/services/auth/consents.py Outdated Show resolved Hide resolved
src/globus_sdk/services/auth/consents.py Outdated Show resolved Hide resolved
src/globus_sdk/services/auth/consents.py Outdated Show resolved Hide resolved
src/globus_sdk/services/auth/consents.py Outdated Show resolved Hide resolved
src/globus_sdk/services/auth/consents.py Outdated Show resolved Hide resolved
src/globus_sdk/services/auth/consents.py Outdated Show resolved Hide resolved
src/globus_sdk/services/auth/consents.py Outdated Show resolved Hide resolved
@derek-globus derek-globus merged commit b12b0ce into globus:main Apr 19, 2024
16 checks passed
@derek-globus derek-globus deleted the consent-forest-sc-30764 branch April 22, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbryan-globus joshbryan-globus joshbryan-globus left review comments

@sirosen sirosen sirosen approved these changes

@aaschaer aaschaer Awaiting requested review from aaschaer aaschaer is a code owner

@ada-globus ada-globus Awaiting requested review from ada-globus ada-globus is a code owner

@kurtmckee kurtmckee Awaiting requested review from kurtmckee kurtmckee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derek-globus @kurtmckee @sirosen @joshbryan-globus