Connect requirements to blocks #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adding requirements
In order to get correct validation error messages, also name relation fields after the model (e.g. requirements) instead of the ids (e.g. requirement_ids). Also adds the laravel-fillable-relations package and uses it to automatically save the block on an observation.
…-fillable-relations The laravel-fillable-relations package overwrote how the static Model::create method works, and this broke with our current approach for always setting the email of Hitobito users to verified. Fixed by using a more standard approach for setting this (do it in the constructor instead of the newInstance method)
carlobeltrame
force-pushed
the
connect-requirements-to-blocks
branch
from
3270b18 to
5d1e5aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
Also, refactors the FormRequests so that validation of one-to-many and many-to-many associations can be done directly in the FormRequests, and renames fields like
requirement_idstorequirementsetc. to still provide correct validation error messages.Now, you can validate whether the related entites (that the user selects in a Multiselect dropdown) all exist in the course:
[ 'requirements' => 'required|regex:/^\d+(,\d+)*$/|allExistInCourse', 'block' => 'required|regex:/^\d+$/|existsInCourse'`, ]