Fix sort and sort-by for most basic cases. #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this patch: $ ./bin/linux_amd64/glj test/glojure/test_glojure/numbers.glj Testing glojure.test-glojure.numbers Ran 42 tests containing 2744 assertions. 0 failures, 0 errors. Before this patch: $ ./bin/linux_amd64/glj test/glojure/test_glojure/numbers.glj Testing glojure.test-glojure.numbers FAIL in (nil) (:) expected: (= vals (map wrapped inputs)) actual: (not (= [\� \ \ \ \� \� \� \� \�] (\� \ \ \ \� \� \� \ \))) FAIL in (nil) (:) expected: (= vals (map wrapped inputs)) actual: (not (= [255 0 1 127 255 255 255 255 255] (255 0 1 127 255 255 255 0 0))) FAIL in (nil) (:) expected: (= vals (map wrapped inputs)) actual: (not (= [-1 0 1 127 32767 -1 -1 -1 -1] (-1 0 1 127 32767 -1 -1 0 0))) FAIL in (nil) (:) expected: (= vals (map wrapped inputs)) actual: (not (= [-1 0 1 127 32767 2147483647 9223372036854775807 9223372036854775807 9223372036854775807] (-1 0 1 127 32767 2147483647 9223372036854775807 -9223372036854775808 -9223372036854775808))) FAIL in (nil) (:) expected: (= vals (map wrapped inputs)) actual: (not (= [-1 0 1 127 32767 2147483647 9223372036854775807 9223372036854775807 9223372036854775807] (-1 0 1 127 32767 2147483647 9223372036854775807 -9223372036854775808 -9223372036854775808))) Ran 42 tests containing 2744 assertions. 5 failures, 0 errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still cases that fail, and some disabled tests for those.
But this is a big usability win, imho.