Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to go1.21, Request wrapper #34

Merged
merged 5 commits into from
Dec 8, 2024
Merged

Downgrade to go1.21, Request wrapper #34

merged 5 commits into from
Dec 8, 2024

Conversation

glossd
Copy link
Owner

@glossd glossd commented Dec 7, 2024

Fixes #33
Because I created fetch.Request with embedded http.Request, my library no longer needs to the PathValue() method, allowing me to downgrade to go1.21
Migration guide:
If you have ever discovered fetch.Request function before, replace it with fetch.Do
If you used json tags in the input of ToHandlerFunc, wrap the input with fetch.Request and access the needed data.
I removed DuplicateHeaders field from everywhere, just rely on Headers

@glossd glossd changed the title Request wrapper WIP Request wrapper Dec 7, 2024
@glossd glossd changed the title WIP Request wrapper Downgrade to go1.21, Request wrapper Dec 8, 2024
@glossd glossd merged commit 8735d26 into master Dec 8, 2024
1 check passed
@glossd glossd deleted the request-wrapper branch December 8, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToHttpFunc tags are confusing.
1 participant