Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 Fix issues reported by CRAN #8

Merged
merged 12 commits into from
Dec 1, 2022
Merged

🩹 Fix issues reported by CRAN #8

merged 12 commits into from
Dec 1, 2022

Conversation

jsnel
Copy link
Member

@jsnel jsnel commented Dec 1, 2022 •
edited
Loading

This PR addresses recent warnings in the CRAN build system, which - left unaddressed - resulted in the TIMP package (hopefulyl only temporarily) being pulled from CRAN.

Package ‘TIMP’ was removed from the CRAN repository.
Formerly available versions can be obtained from the archive.
Archived on 2022-11-21 as issues were not corrected despite reminders.
A summary of the most recent check results can be obtained from the check results archive.
Please use the canonical form https://cran.r-project.org/package=TIMP to link to this page.

Change summary

Relevant changes:

  • ♻️ Refactor c function to conform to modern standards
    • Fixes: (warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype])
  • ♻️Uses is(x,"name") instead of class(x)=="name" comparison
  • Other changes:
  • 🛡️Update URLs from http to https
  • 📚Update DOI urls to use \doi command
  • 🧹Remove unused NEWS file

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@jsnel jsnel changed the title 🚧Add autogenerated files to gitignore 🚧 Fix issues reported by CRAN Dec 1, 2022
jsnel added 8 commits December 1, 2022 22:38
@jsnel
🚧 Update .gitignore
143e8d6
@jsnel
🛡️Update URLs from http to https
634ef36
@jsnel
♻️ Refactor c function to conform to modern standards
69b7c6f 
Fixes:
```
warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
```
@jsnel
📚Update DOI urls to use \doi command
4351e8e
@jsnel
🧹Cleanup generated files after running example code in build process
0f97a39 
Using file.remove to delete files that were created as part of the build process to ensure they don't litter the root directory and trigger NOTEs.
@jsnel
♻️Uses is(x,"name") instead of class(x)=="name" comparison
c3ca17a 
Was triggering a NOTE
@jsnel
🧹Autoformatted to remove trailing spaces
128a25f
@jsnel
🧹Cleanup build process
8660c77
jsnel added 2 commits December 2, 2022 00:00
@jsnel
🧹Avoid using LaTeX specials
9a86e6c 
Fixes:
```
checkRd: (-1) dat-class.Rd:47: Escaped LaTeX specials: \_
checkRd: (-1) dat-class.Rd:48: Escaped LaTeX specials: \_
checkRd: (-1) dat-class.Rd:49: Escaped LaTeX specials: \_
checkRd: (-1) dat-class.Rd:50: Escaped LaTeX specials: \_
```
@jsnel
🧹 Remove unused NEWS file
3f5f3e1 
For the latest NEWS see: 
- https://github.com/glotaran/TIMP
@jsnel jsnel requested a review from ism200 December 1, 2022 23:09
@jsnel jsnel marked this pull request as ready for review December 1, 2022 23:09
@jsnel jsnel changed the title 🚧 Fix issues reported by CRAN 🩹 Fix issues reported by CRAN Dec 1, 2022
@jsnel jsnel merged commit e1632b8 into glotaran:main Dec 1, 2022
@jsnel jsnel deleted the fix/cran_issues branch December 1, 2022 23:28
@jsnel jsnel mentioned this pull request Dec 1, 2022
Merged
1 task
@ism200
Copy link
Collaborator

ism200 commented Dec 2, 2022

hartelijk bedankt voor de fixes!

jsnel added a commit that referenced this pull request Dec 3, 2022
@jsnel
⬆Ready to release version 1.13.5 (to re-publish on CRAN) (#9)
90ffeba 
A new release of TIMP to fix some issue arising from more stringent requirements in the CRAN package build process

Changes include:
-  🩹 Fix issues reported by CRAN ( PR #8 )
- 📚 Updates to jstatsoft URLs ( Issue #7 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ism200 ism200 Awaiting requested review from ism200

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsnel @ism200