Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Shift irf derivatives in plot_coherent_artifact by irf position #136

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Jan 31, 2023

This PR adds main_irf_nr to plot_coherent_artifact which defaults to 0 and shifts the IRF derivatives to by the position of the IRF component with index 0. If main_irf_nr is set to None the IRF shifting is deactivated.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner January 31, 2023 23:17
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 31, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.35%.

Quality metrics Before After Change
Complexity 6.83 ⭐ 6.84 ⭐ 0.01 👎
Method Length 221.50 ⛔ 237.50 ⛔ 16.00 👎
Working memory 15.71 ⛔ 16.70 ⛔ 0.99 👎
Quality 37.16% 😞 35.81% 😞 -1.35% 👎
Other metrics Before After Change
Lines 127 134 7
Changed files Quality Before Quality After Quality Change
pyglotaran_extras/plotting/plot_coherent_artifact.py 37.16% 😞 35.81% 😞 -1.35% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pyglotaran_extras/plotting/plot_coherent_artifact.py plot_coherent_artifact 7 ⭐ 366 ⛔ 17 ⛔ 34.69% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@s-weigand s-weigand marked this pull request as draft January 31, 2023 23:17
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/improve-plot_coherent_artifact

@s-weigand
Copy link
Member Author

This PR is a draft since it depends on #135, after #135 is merged I will rebase it and remove the draft status.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 44.97% // Head: 44.97% // No change to project coverage 👍

Coverage data is based on head (137ad2a) compared to base (137ad2a).
Patch has no changes to coverable lines.

❗ Current head 137ad2a differs from pull request most recent head 6f337b5. Consider uploading reports for the commit 6f337b5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   44.97%   44.97%           
=======================================
  Files          29       29           
  Lines         916      916           
  Branches      133      133           
=======================================
  Hits          412      412           
  Misses        497      497           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@s-weigand s-weigand force-pushed the improve-plot_coherent_artifact branch from f5aafe6 to 6f337b5 Compare February 1, 2023 18:55
@s-weigand s-weigand marked this pull request as ready for review February 1, 2023 18:57
@jsnel jsnel merged commit ce5bcc2 into glotaran:main Feb 3, 2023
@s-weigand s-weigand deleted the improve-plot_coherent_artifact branch February 3, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants