Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Add minor ticks to linlog plots #183

Merged
merged 2 commits into from
Jul 2, 2023
Merged

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Jul 2, 2023

This change adds minor ticks to linlog plots which makes it easier to differentiate between the linear and logarithmic parts.

Before

image

After

image

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner July 2, 2023 16:47
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/symlog-ticks

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.78 ⚠️

Comparison is base (ee65602) 44.08% compared to head (2500e0a) 43.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   44.08%   43.30%   -0.78%     
==========================================
  Files          27       27              
  Lines         939      979      +40     
  Branches      137      142       +5     
==========================================
+ Hits          414      424      +10     
- Misses        518      548      +30     
  Partials        7        7              
Impacted Files Coverage Δ
pyglotaran_extras/plotting/utils.py 28.05% <17.85%> (-2.58%) ⬇️
pyglotaran_extras/plotting/plot_data.py 34.04% <33.33%> (-0.05%) ⬇️
pyglotaran_extras/plotting/plot_svd.py 20.54% <33.33%> (+0.54%) ⬆️
pyglotaran_extras/plotting/plot_concentrations.py 43.75% <50.00%> (+0.89%) ⬆️
pyglotaran_extras/plotting/plot_residual.py 29.03% <50.00%> (+1.44%) ⬆️
pyglotaran_extras/plotting/plot_traces.py 31.37% <50.00%> (+0.76%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@jsnel jsnel merged commit abac208 into glotaran:main Jul 2, 2023
@s-weigand s-weigand deleted the symlog-ticks branch July 2, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants