Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Add das_cycler and svd_cycler to plot collection functions #218

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Nov 4, 2023

This change allows setting a different cycler for DAS and SVD plots.

I introduced an Unset singleton (similar to pydantics Undefined) in order to allow this change without regressing current behavior.

I also deprecated the cycler argument to plot_sv_data and plot_sv_residual since it doesn't have an effect since there is only a single scatter lines plot where the style is overwritten in the plot method call.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner November 4, 2023 13:38
Copy link
Contributor

github-actions bot commented Nov 4, 2023

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/multiple-cylers

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pyglotaran_extras/types.py 100.00% <100.00%> (ø)
pyglotaran_extras/plotting/plot_data.py 35.41% <50.00%> (+1.37%) ⬆️
pyglotaran_extras/plotting/plot_spectra.py 20.75% <20.00%> (+0.75%) ⬆️
pyglotaran_extras/plotting/plot_svd.py 23.68% <33.33%> (+2.55%) ⬆️
pyglotaran_extras/plotting/plot_overview.py 36.06% <10.00%> (-2.83%) ⬇️

📢 Thoughts on this report? Let us know!.

pyglotaran_extras/types.py Outdated Show resolved Hide resolved
Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice workaround with the Unset type. A bit confusing to reason but it shouldn't really be a problem as it's mostly an internal API thing.

@jsnel jsnel merged commit b04a61e into glotaran:main Nov 4, 2023
27 checks passed
@s-weigand s-weigand deleted the multiple-cylers branch November 4, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants