Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚇🧹 Switch back to GeekyEggo/delete-artifact #261

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Mar 20, 2024

Switch back to GeekyEggo/delete-artifact after the permission issue fix was released.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner March 20, 2024 18:09
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/upstream-delete-artifact

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @s-weigand - I've reviewed your changes and they look great!

General suggestions:

  • Ensure that the version pinning to GeekyEggo/delete-artifact@v5 is intentional and the most appropriate for stability and feature needs.
  • Verify the integration of GeekyEggo/delete-artifact@v5 in the workflow through end-to-end testing to ensure no disruptions in CI/CD processes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.77%. Comparing base (b880df9) to head (e8fd953).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   44.77%   44.77%           
=======================================
  Files          27       27           
  Lines        1043     1043           
  Branches      162      162           
=======================================
  Hits          467      467           
  Misses        568      568           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major release v5 as expected.

@s-weigand s-weigand merged commit a9a6406 into glotaran:main Mar 22, 2024
31 checks passed
@s-weigand s-weigand deleted the upstream-delete-artifact branch March 22, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants