-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧🚀🚇♻️ Shape up for release #40
Conversation
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 4.26% 40.70% +36.43%
==========================================
Files 17 22 +5
Lines 516 597 +81
Branches 70 77 +7
==========================================
+ Hits 22 243 +221
+ Misses 494 354 -140
Continue to review full report at Codecov.
|
Slightly adjusted copy paste from pyglotaran https://github.com/glotaran/pyglotaran/blob/d1e36a93d2c75ec1a93d4eacea5eba2d49b6f130/glotaran/deprecation/deprecation_utils.py#L1
And adjusted res arg for 'plot_simple_overview' to be DatasetConvertible, to be consistent with 'plot_overview'
…style This should also prevent style resetting
06093b3
to
c0d7120
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
This PR brings the package in shape for its first release (
0.5.0rc1
).None:
Not to break user code the change for plot functions to return
fig, axes
needs to be done in 3 steps:1.) Add argument
figure_only=True
(current behavior) and warn the user to change it (part of this PR)2.) In
0.7.0
replacefigure_only=True
, with**kwargs
and warn the user3.) In
0.9.0
remove**kwargs
again.This way users can gradually upgrade and get instructions on how to change the code w/o having broken code.
Change summary
Checklist
Closes issues
closes #17
closes #18
closes #20
closes #21