Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Improve legend placement in plot_data_overview #77

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Apr 9, 2022

Just some minor improvements on pacing legends for plot_data_overview

Before

Legend hides part of the plot and has redundant information since the legends for LSV and RSV link the same color to the same index.
image

When users want to plot more vectors things get out of control
image

After

image

Also plays nicely if users want to plot more vectors
image

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner April 9, 2022 08:28
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2022

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/improve-dataplot-legend-placement

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #77 (e189612) into main (68fb194) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   40.85%   40.72%   -0.13%     
==========================================
  Files          22       22              
  Lines         629      631       +2     
  Branches       90       91       +1     
==========================================
  Hits          257      257              
- Misses        372      374       +2     
Impacted Files Coverage Δ
pyglotaran_extras/plotting/plot_data.py 37.50% <0.00%> (-2.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68fb194...e189612. Read the comment docs.

@s-weigand s-weigand force-pushed the improve-dataplot-legend-placement branch from 7b7f42a to e189612 Compare April 9, 2022 08:43
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 9, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.71%.

Quality metrics Before After Change
Complexity 2.81 ⭐ 3.74 ⭐ 0.93 👎
Method Length 110.50 🙂 120.50 😞 10.00 👎
Working memory 14.67 😞 14.78 😞 0.11 👎
Quality 51.98% 🙂 49.27% 😞 -2.71% 👎
Other metrics Before After Change
Lines 83 81 -2
Changed files Quality Before Quality After Quality Change
pyglotaran_extras/plotting/plot_data.py 51.98% 🙂 49.27% 😞 -2.71% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pyglotaran_extras/plotting/plot_data.py plot_data_overview 4 ⭐ 207 ⛔ 16 ⛔ 44.92% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@jsnel jsnel merged commit a6fc162 into glotaran:main Apr 10, 2022
@s-weigand s-weigand deleted the improve-dataplot-legend-placement branch April 10, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants