Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements #1370

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Various improvements #1370

merged 2 commits into from
Oct 17, 2023

Conversation

jsnel
Copy link
Member

@jsnel jsnel commented Oct 17, 2023

Adds dry run to optimze
Fixes a pytest issue

@jsnel jsnel requested review from a team, s-weigand and joernweissenborn as code owners October 17, 2023 22:08
@jsnel
Copy link
Member Author

jsnel commented Oct 17, 2023

Wrong target

@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch jsnel/pyglotaran/various_improvements

@jsnel jsnel closed this Oct 17, 2023
@sourcery-ai sourcery-ai bot mentioned this pull request Oct 17, 2023
Closed
@jsnel jsnel reopened this Oct 17, 2023
@jsnel jsnel changed the base branch from main to staging October 17, 2023 22:10
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 10 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 32 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

joernweissenborn
joernweissenborn approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@joernweissenborn joernweissenborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsnel jsnel merged commit e1ca87c into glotaran:staging Oct 17, 2023
19 of 51 checks passed
@jsnel jsnel deleted the various_improvements branch October 17, 2023 22:12
jsnel added a commit to jsnel/pyglotaran that referenced this pull request Jun 2, 2024
@jsnel
Various improvements (glotaran#1370)
5b32e31 
* Add dry run option to optimize

* Small pytest fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joernweissenborn joernweissenborn joernweissenborn approved these changes

@s-weigand s-weigand Awaiting requested review from s-weigand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsnel @joernweissenborn