Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 Fix dataset weights #1384

Merged
merged 1 commit into from
Oct 22, 2023
Merged

🩹 Fix dataset weights #1384

merged 1 commit into from
Oct 22, 2023

Conversation

jsnel
Copy link
Member

@jsnel jsnel commented Oct 22, 2023

Tested with freshly ported ex_two_datasets example

@jsnel jsnel requested review from a team, s-weigand and joernweissenborn as code owners October 22, 2023 08:33
@jsnel jsnel changed the base branch from main to staging October 22, 2023 08:33
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch jsnel/pyglotaran/fix_dataset_weights

@codecov
Copy link

codecov bot commented Oct 22, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
glotaran/optimization/data.py 87.1% <100.0%> (ø)

📢 Thoughts on this report? Let us know!.

s-weigand
s-weigand approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@s-weigand s-weigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seams right since get_model_weight(model) creates a new array without having side effects. Good catch 👍

@s-weigand s-weigand force-pushed the fix_dataset_weights branch from fa5d54c to 0a73261 Compare October 22, 2023 13:19
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

joernweissenborn
joernweissenborn approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@joernweissenborn joernweissenborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for fixing.

@jsnel jsnel merged commit ace4db8 into glotaran:staging Oct 22, 2023
16 of 32 checks passed
@jsnel jsnel deleted the fix_dataset_weights branch October 22, 2023 14:50
jsnel added a commit to jsnel/pyglotaran that referenced this pull request Jun 2, 2024
@jsnel
Fix dataset weight application (glotaran#1384)
30b85ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-weigand s-weigand s-weigand approved these changes

@joernweissenborn joernweissenborn joernweissenborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsnel @joernweissenborn @s-weigand