Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚇🩹 Fix publish workflow #1401

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Dec 6, 2023

This fixes the permissions of the publishing workflow.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested review from a team as code owners December 6, 2023 22:41
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/fix-publish-ci

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.7.1 vs. main

All benchmarks:

| Change   | Before [535acaaa] <v0.7.1>   | After [620eaa47]    |   Ratio | Benchmark (Parameter)                   |
|----------|------------------------------|---------------------|---------|-----------------------------------------|
|          | 237M                         | 237M                |    1    | IntegrationTwoDatasets.peakmem_optimize |
|          | 1.37±0.09s                   | 1.41±0.09s          |    1.03 | IntegrationTwoDatasets.time_optimize    |

Benchmark diff main vs. PR

All benchmarks:

| Change   | Before [620eaa47]    | After [75483b43]    |   Ratio | Benchmark (Parameter)                   |
|----------|----------------------|---------------------|---------|-----------------------------------------|
|          | 237M                 | 235M                |    0.99 | IntegrationTwoDatasets.peakmem_optimize |
|          | 1.41±0.09s           | 1.31±0.02s          |    0.93 | IntegrationTwoDatasets.time_optimize    |

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (620eaa4) 88.5% compared to head (75483b4) 88.5%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1401   +/-   ##
=====================================
  Coverage   88.5%   88.5%           
=====================================
  Files        107     107           
  Lines       5128    5128           
  Branches     962     962           
=====================================
  Hits        4542    4542           
  Misses       471     471           
  Partials     115     115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jsnel jsnel merged commit 1fb14bb into glotaran:main Dec 6, 2023
38 checks passed
@jsnel jsnel deleted the fix-publish-ci branch December 6, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants