-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️🧰 Autoupdate pre-commit config #1438
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @s-weigand - I've reviewed your changes and they look great!
General suggestions:
- Ensure that the updated pre-commit hooks do not introduce any unintended formatting changes.
- Verify that all dependencies updated in the pre-commit config are compatible with the project's current setup.
- Consider running the full test suite to ensure that the updates do not affect the project's functionality.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #1438 +/- ##
=========================================
- Coverage 84.9% 84.9% -0.1%
=========================================
Files 91 91
Lines 3742 3740 -2
Branches 728 728
=========================================
- Hits 3178 3176 -2
+ Misses 450 448 -2
- Partials 114 116 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a lot of changes but that's just the added (before missing) empty line following module docstrings.
Yeah pretty much the same as #1407 on |
Note this is an update for the staging branch. * 🧰⬆️ Update pre-commit config * 🧹 Run pre-commit on all files
Minor tooling update
Change summary
Checklist