Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️🧰 Autoupdate pre-commit config #1438

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

s-weigand
Copy link
Member

Minor tooling update

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand added the staging Issues found in staging branch label Mar 17, 2024
@s-weigand s-weigand requested review from jsnel, a team and joernweissenborn as code owners March 17, 2024 17:34
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/update-pre-commit-staging

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @s-weigand - I've reviewed your changes and they look great!

General suggestions:

  • Ensure that the updated pre-commit hooks do not introduce any unintended formatting changes.
  • Verify that all dependencies updated in the pre-commit config are compatible with the project's current setup.
  • Consider running the full test suite to ensure that the updates do not affect the project's functionality.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.9%. Comparing base (60f9c7c) to head (b8b2df2).

Additional details and impacted files
@@            Coverage Diff            @@
##           staging   #1438     +/-   ##
=========================================
- Coverage     84.9%   84.9%   -0.1%     
=========================================
  Files           91      91             
  Lines         3742    3740      -2     
  Branches       728     728             
=========================================
- Hits          3178    3176      -2     
+ Misses         450     448      -2     
- Partials       114     116      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a lot of changes but that's just the added (before missing) empty line following module docstrings.

@jsnel jsnel merged commit 87f9303 into glotaran:staging Mar 17, 2024
21 of 34 checks passed
@s-weigand
Copy link
Member Author

s-weigand commented Mar 17, 2024

It looks like a lot of changes but that's just the added (before missing) empty line following module docstrings.

Yeah pretty much the same as #1407 on main

@s-weigand s-weigand deleted the update-pre-commit-staging branch March 17, 2024 23:21
jsnel pushed a commit to jsnel/pyglotaran that referenced this pull request Jun 2, 2024
Note this is an update for the staging branch.

* 🧰⬆️ Update pre-commit config
* 🧹 Run pre-commit on all files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Issues found in staging branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants