-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚇🧹 Switch back to GeekyEggo/delete-artifact #1441
🚇🧹 Switch back to GeekyEggo/delete-artifact #1441
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @s-weigand - I've reviewed your changes and they look great!
General suggestions:
- Confirm that GeekyEggo/delete-artifact@v5 includes all necessary fixes and enhancements for your workflow requirements.
- Consider adding a brief comment next to the action usage to document the reason for the switch back for future reference.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Benchmark is done. Checkout the benchmark result page. Benchmark diff v0.7.2 vs. main
Benchmark diff main vs. PR
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
=====================================
Coverage 88.6% 88.6%
=====================================
Files 107 107
Lines 5128 5133 +5
Branches 962 965 +3
=====================================
+ Hits 4544 4549 +5
Misses 468 468
Partials 116 116 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V5 of action as expected
Switch back to
GeekyEggo/delete-artifact
after the permission issue fix was released.Change summary
Checklist