Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚇🧹 Switch back to GeekyEggo/delete-artifact #1441

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Mar 20, 2024

Switch back to GeekyEggo/delete-artifact after the permission issue fix was released.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested review from a team as code owners March 20, 2024 18:15
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/switch-back-delete-artifact

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @s-weigand - I've reviewed your changes and they look great!

General suggestions:

  • Confirm that GeekyEggo/delete-artifact@v5 includes all necessary fixes and enhancements for your workflow requirements.
  • Consider adding a brief comment next to the action usage to document the reason for the switch back for future reference.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.github/workflows/integration-tests.yml Show resolved Hide resolved
Copy link
Contributor

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.7.2 vs. main

All benchmarks:

| Change   | Before [1fb14bbc] <v0.7.2>   | After [f95130fd]    |   Ratio | Benchmark (Parameter)                   |
|----------|------------------------------|---------------------|---------|-----------------------------------------|
|          | 241M                         | 241M                |    1    | IntegrationTwoDatasets.peakmem_optimize |
|          | 1.38±0.03s                   | 1.49±0.1s           |    1.08 | IntegrationTwoDatasets.time_optimize    |

Benchmark diff main vs. PR

All benchmarks:

| Change   | Before [f95130fd]    | After [f7e6a218]    |   Ratio | Benchmark (Parameter)                   |
|----------|----------------------|---------------------|---------|-----------------------------------------|
|          | 241M                 | 241M                |    1    | IntegrationTwoDatasets.peakmem_optimize |
|          | 1.49±0.1s            | 1.40±0.08s          |    0.94 | IntegrationTwoDatasets.time_optimize    |

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.6%. Comparing base (2c88dce) to head (f7e6a21).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1441   +/-   ##
=====================================
  Coverage   88.6%   88.6%           
=====================================
  Files        107     107           
  Lines       5128    5133    +5     
  Branches     962     965    +3     
=====================================
+ Hits        4544    4549    +5     
  Misses       468     468           
  Partials     116     116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V5 of action as expected

@s-weigand s-weigand merged commit 633b4c2 into glotaran:main Mar 22, 2024
41 checks passed
@s-weigand s-weigand deleted the switch-back-delete-artifact branch March 22, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants