Maintain all pending index entries. #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaander
requested review from
a team,
tcmoore3,
tommy-waltmann and
syjlee
and removed request for
a team
tcmoore3
approved these changes
Jan 19, 2024
syjlee
approved these changes
Jan 20, 2024
tommy-waltmann
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug that lost index entries in some very specific corner cases.
Motivation and Context
Whenever
gsd_flushis called afterwrite_chunkbut beforeend_frame, it kept one of the pending entries and repeated it N times instead of keeping all N pending entries.How Has This Been Tested?
The added unit test checks that the bug is fixed.
Checklist:
doc/credits.rst) in the pull request source branch.CHANGELOG.rst.