Skip to content

add administration/forms #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

add administration/forms #154

wants to merge 3 commits into from

Conversation

Otijom
Copy link
Collaborator

@Otijom Otijom commented Jun 19, 2025

not yet finished, 1st proofreading by Clément

@Otijom Otijom requested a review from ccailly June 19, 2025 10:05
Copy link
Member

@ccailly ccailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything that is written seems correct to me.
I think the section on forms is not yet complete, but some things are not documented :

  • Conditions for the visibility of the submit button
  • Validation conditions

@trasher trasher marked this pull request as draft June 19, 2025 12:29
@trasher
Copy link
Collaborator

trasher commented Jun 19, 2025

Converted to draft since this is not finished

@Otijom Otijom marked this pull request as ready for review June 25, 2025 08:13
Comment on lines +118 to 120
[o:glpi:p:glpi-user-documentation:r:modules--administration--entity-entities]
file_filter = source/locale/<lang>/LC_MESSAGES/modules/administration/entities.po
source_file = build/locale/modules/administration/entities.pot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not you use a double -- everywhere?
Paths for file_filter ans source file seems incorrect.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I guess source/modules/administration/entities.rst should have been removed.

Forms
=====

Since GLPI 11, forms are now native, so the formcreator plugin is no longer required. Forms can be migrated from formcreator to forms.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Since GLPI 11, forms are now native, so the formcreator plugin is no longer required. Forms can be migrated from formcreator to forms.
Since GLPI 11, forms are native, so the formcreator plugin is no longer required. Forms can be migrated from formcreator to forms.

Comment on lines +78 to +79
Basic informations
~~~~~~~~~~~~~~~~~~
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Basic informations
~~~~~~~~~~~~~~~~~~
Basic information
~~~~~~~~~~~~~~~~~

Each question has its own **title** field (identified by new question) and will be **visible to the user**.
Each question **can be made mandatory** so that the user has no other choice than to fill in this field to validate their form

There are actually 11 possible question types:
Copy link
Collaborator

@trasher trasher Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are actually 11 possible question types:
There are actually several possible question types:

This field has additional options:

* *Text*: Allows you to enter text (alphanumeric)
* *Emails*: Allows you to enter email addresses only (xxxxxx@xxxxxx.xx)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* *Emails*: Allows you to enter email addresses only (xxxxxx@xxxxxx.xx)
* *Emails*: Allows you to enter email addresses only

@trasher trasher requested a review from cconard96 June 25, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants