Improve Brother SNMP printer inventory (ifType) #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardomozart
changed the title
It's the field that determines the interface name on GLPI server
g-bougard
requested changes
Jan 26, 2025
There was a problem hiding this comment.
I'm essentially okay with the PR.
Bellow you'll see essentially advice. B the "defined()" checks here are essentials.
Also can you attach another walk this time with the right format using the command described here: https://glpi-agent.readthedocs.io/en/nightly/bug-reporting.html#snmpwalk-output
Thank you
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
|
Hello @g-bougard, I've updated this PR with your suggestions, tested it and it's working as expected. Also updated the snmpwalk file. |
g-bougard
reviewed
Jan 30, 2025
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
|
Helo @g-bougard, tested your commit and it's working as expected. |
|
Thank you for your contribution @eduardomozart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the inventory of network ports of Brother printers. I have a HL-1210W printer which reports it's ifType as "
iso88023Csmacd(7)" (Ethernet) instead of "ieee80211(71)" (Wireless). I'd opened a bug report with Brother but it's a common issue with other models as Brother QL-710W. It happens because Brother uses https://mibs.observium.org/mib/BROTHER-MIB/#brMultiIFConfigureTable to determine interface type. This PR queries those values and change the port type accordingly.I also would like to know if it's possible to set the Wi-Fi Network which the printer belongs through netinventory tasks, so I could use
$brpsWLanName->{(keys %{$brpsWLanName})[0]}as seen in ae8828b. The only solution I could found was renaming the interface name to reflect the Wi-Fi Network name, but if the interface name changes, the interface metrics history is "lost" (unassociated) since a new interface is created in GLPI.Brother HL-1210W snmpwalk: snmpwalk-brother.txt