Update install-deb.sh #842
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-bougard
requested changes
Jan 30, 2025
| @@ -92,6 +93,7 @@ echo | |||
| if $tasknetwork; then | |||
| echo "network task is requested" | |||
| echo "installing dependencies" | |||
| apt update | |||
There was a problem hiding this comment.
I don't think this is required if still done on l.64.
| @@ -106,6 +108,7 @@ echo | |||
| if $taskdeploy; then | |||
| echo "deploy task is requested" | |||
| echo "installing dependencies" | |||
| apt update | |||
There was a problem hiding this comment.
As above, I don't think this is required if still done on l.64.
|
Hi @cbka I finally merge manually to apply myself the patch I requested: only one Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add apt update before apt-get install
this is useful when using the script in e.g. ansible environments because the install script itself becomes independent from previous operations.