Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ukrainian localization problem #3200

Closed
ferdmanp opened this issue Nov 22, 2017 · 5 comments
Closed

Ukrainian localization problem #3200

ferdmanp opened this issue Nov 22, 2017 · 5 comments
Assignees
Milestone

Comments

@ferdmanp
Copy link

With feature "Use rich text for helpdesk" enabled, ran into following issue. When using Ukrainian language as interface language ("Українська" in My Settings>Personalization>Language dropdown)

  1. "Description" field in ticket form not showing TinyMCE toolbar, and shows HTML tags between words
  2. "Linked tickets" not showing dropdown for ticket selection.
@flegastelois
Copy link
Member

flegastelois commented Nov 22, 2017

I confirm the first bug, we have a javascript error:

image

Because of "single quote" in this translation string:

msgstr "Поле опису обов'язкове"

The second bug stems from the first.

@flegastelois flegastelois added this to the 9.2.2 milestone Nov 22, 2017
@AnaelMobilia
Copy link
Contributor

Hello,

I have fix the issue on transifex both for 9.2 and 9.3 branches.
The thing is to use html entities on this specific case (we cannot use \ to escape the char).

So ' become ' and all's done.

I've tested the compilation of the mo file 👍
image

@trasher to be closed, this issue need an update of the mo / po files on the glpi repository.
I dunno if I can made this ?

Regards,
Anael

@trasher
Copy link
Contributor

trasher commented Nov 27, 2017

Thanks to get locale fixed; but I guess this is still an issue; GLPI should take care of escaping for javascript output

@AnaelMobilia
Copy link
Contributor

@trasher GLPI use the compiled mo file.
Have we a way to get the value before it's put on JS ?

If no, we could add specific tules on the pl script to "protect" these type of char ?

Regards,
Anael

@trasher
Copy link
Contributor

trasher commented Nov 28, 2017

@AnaelMobilia basically, GLPI uses __() method for translations, and __s() when some escaping is required. I guess the first has been used instead of the second somewhere here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants