Browse items by category

[Rom1-B]

Browse items by category, as already exists for kb items

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	!22497

[Rom1-B]

It should be ok now

[cedric-anne]

For me, this PR is almost ready to be merged.

The tree display should be improved. On my browser, the left border seems to be missing

Also, I still have some edge cases that may require a fix.

1. The selected category is not stored, so when the page is refresh (manually, or when user changes displayed columns), the previously selected category is lost and the items without any category are displayed.

2. When adding a new criterion, or when switching to "trashbin" view, page is refreshed, and selected category is lost. Even if it was stored, it may be empty when using new criteria, so it may not be present in the tree.

[cedric-anne]

We do a functionnal review with @orthagh and here are our comments.

1. This feature should be remove on tickets for now, we may reactivate it on a future GLPI version, but with some enhancements. No need to clean the code, just remove usage of Glpi\Features\TreeBrowse in CommonITILObject.

2. When the selected category contains no elements, it should still be displayed and selected in the tree, so user will not be "lost" when changing criteria result in having no elements in current category.

3. When the browse view is displayed, the javascript logic behind the search view seems not correctly handled. Indeed, changing criteria triggers a full page refresh, changing the number of items displayed is not working, ...

4. The tree seems to be build using a limited search results, so the number of items in category tree is not correct. For instance, if there is 10 categories with 1 item in each, they will be all displayed when at least 10 rows/page are displayed, but the tree will be limited to 5 categories when 5 rows/page are displayed.

5. When pagination is used, a new criteria Characteristics - Heading > is > ... is added to search criteria. So once page is reload, tree contains only the current category and is not browsable anymore.

6. On browse view, a scrollbar is always added, even when there is only a few items displayed. Removing the height: 100% on #tree_browse style seems to fix this, but it may have side effects on KB view.

7. The category selected by default (Without category) has no "active" style, so user may not understand that results are filtered.

[cconard96]

It looks like when switching to the tree browse view, it replaces the search-display-data element and doesn't use the display_data.html.twig template so the JS isn't initialized for fluid search.
I think a new view would have to be created, possibly extending js/modules/Search/Table.js to handle it.

I can work on fluid search compatibility if you want.

[cedric-anne]

@Rom1-B Can you check if 817c07d fixes latests issues and integrate it in this PR ?

[cedric-anne]

This is still not OK.

When you use any of the search actions (change a criteria, use the pagination, ...), the category filter is not applied anymore.

[cconard96]

I thought so so I made my PR a draft. It will need some changes on the JS side to inject the search criteria.

[cedric-anne]

@cconard96 Do not hesitate to push your fixes here.

[cconard96]

I'm not sure if I can. I've tried for other PRs in the past but I don't have access.

I thought only repo maintainers could push to other people's PRs.

[Rom1-B]

It is not yet OK. The criteria are not applied immediately, you have to apply twice.
I must be missing something.

[cconard96]

I thought so so I made my PR a draft. It will need some changes on the JS side to inject the search criteria.

With the category tree filtering results after the regular search is applied, I'm not sure of the correct fix.

Changes were made.

[cedric-anne]

As seen internally, I merge this to be able to integrate it in 10.0.0-rc. Latest bug have to be fixed in another PR soon.