Do not present deleted actors to BR for Tickets #12422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently BR receive also actors from $this->fields not accounting deleted actors on $input["_actors"] Present new values instead, utilizing "_deleted" keys which come from transformActorsInput()
cedric-anne
approved these changes
Aug 10, 2022
cedric-anne
previously requested changes
Aug 10, 2022
VladoTTX
commented
Aug 22, 2022
trasher
reviewed
Aug 22, 2022
trasher
reviewed
Aug 22, 2022
trasher
approved these changes
Aug 22, 2022
orthagh
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently BR receive also actors from $this->fields not accounting deleted actors on $input["_actors"]
Present new values instead (without deleted actors), utilizing "_deleted" keys which come from transformActorsInput()