Fix Entity dropdown using "multiple" option #12717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity multiple choice dropdown: "Uncaught Exception TypeError: array_combine(): Argument glpi-project#2 ($values) must be of type array, null given in glpi10.0.3/src/Html.php at line 4857" Added Dropdown::testShow to unit test multiple choice dropdown creation on Entity's itemtype
tomolimo
approved these changes
Sep 21, 2022
cedric-anne
changed the title
cedric-anne
reviewed
Sep 21, 2022
cedric-anne
reviewed
Sep 26, 2022
cedric-anne
reviewed
Sep 26, 2022
cedric-anne
approved these changes
Sep 26, 2022
trasher
approved these changes
Sep 26, 2022
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parenthesis to fix error which occurs when creating an Entity multiple choice dropdown: "Uncaught Exception TypeError: array_combine(): Argument 2 ($values) must be of type array, null given in glpi10.0.3/src/Html.php at line 4857"
Added Dropdown::testShow to unit test multiple choice dropdown creation on Entity's itemtype