Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FAQ): visibility as documented (before GLPI 10.1) #13890

Merged
merged 1 commit into from
Jan 31, 2023
Merged

fix(FAQ): visibility as documented (before GLPI 10.1) #13890

merged 1 commit into from
Jan 31, 2023

Conversation

Rom1-B
Copy link
Contributor

@Rom1-B Rom1-B commented Jan 26, 2023 •
edited by cedric-anne
Loading

Fix for bugfix only as discussed in #13455

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets !25313 #12566

AdrienClairembault
AdrienClairembault requested changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'd like to see some additional unit tests on this to ensure it doesn't break again (visibility and the recent issue on categories).

You can look at tests added here (https://github.com/glpi-project/glpi/pull/12922/files#diff-9c345c4cc3f12a0e4643b10935087375017c0c2ae71d850b06cf5c5e8845fd0d), I guess the FAQ part is too lightweight.

AdrienClairembault
AdrienClairembault approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After second thoughts, ok to merge without tests as it wont be merged in main.
However, this mean the separate PR for main should include the tests.

@cedric-anne cedric-anne mentioned this pull request Jan 26, 2023
Closed
2 tasks
@trasher trasher merged commit 855a618 into glpi-project:10.0/bugfixes Jan 31, 2023
@trasher trasher linked an issue Jan 31, 2023 that may be closed by this pull request
FAQ articles can no longer be restricted to entities in their visibility tab #12566
Closed
2 tasks
@Rom1-B Rom1-B deleted the 13455_100bf branch January 31, 2023 14:57
@cedric-anne cedric-anne mentioned this pull request Mar 23, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

@trasher trasher trasher approved these changes

@orthagh orthagh Awaiting requested review from orthagh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAQ articles can no longer be restricted to entities in their visibility tab
4 participants
@Rom1-B @trasher @cedric-anne @AdrienClairembault