Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deprecated warning when sync_field is null #15620

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Avoid deprecated warning when sync_field is null #15620

merged 1 commit into from
Sep 22, 2023

Conversation

AdrienClairembault
Copy link
Contributor

Avoid this deprecation warning:

PHP Deprecated function (8192): strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/glpi/src/Auth.php at line 1515

Since the sync_field allow null values, we should fallback to an empty string to avoid sending invalid parameters to strlen().

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets

@trasher trasher added this to the 10.0.10 milestone Sep 22, 2023
@trasher trasher merged commit ec2666d into glpi-project:10.0/bugfixes Sep 22, 2023
15 checks passed
@AdrienClairembault AdrienClairembault deleted the fix/strlen-depreacted-syncfield branch October 4, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-anne cedric-anne cedric-anne approved these changes

@orthagh orthagh orthagh approved these changes

@trasher trasher trasher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0.10
Development

Successfully merging this pull request may close these issues.
4 participants
@AdrienClairembault @trasher @orthagh @cedric-anne