Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling of broken saved searches #16166

Merged

Conversation

cconard96
Copy link
Contributor

@cconard96 cconard96 commented Dec 7, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

Try to avoid a situation where a single bad saved search could prevent the list of searches from being shown.
Also adds the ability to remove saved searches directly from the list.

src/SavedSearch.php Show resolved Hide resolved
@cedric-anne cedric-anne force-pushed the fix/saved_search_corrupt branch from 0d23249 to 12c56f0 Compare January 11, 2024 13:13
@cedric-anne cedric-anne added this to the 10.0.12 milestone Jan 11, 2024
@trasher trasher merged commit 3e852c1 into glpi-project:10.0/bugfixes Jan 11, 2024
13 checks passed
anthonymontebrun pushed a commit to IT-Gouvernance/glpi that referenced this pull request Jul 11, 2024
* handle corrupt saved searches

* small adjusments

---------

Co-authored-by: Cédric Anne <cedric.anne@gmail.com>
btry pushed a commit to btry/glpi that referenced this pull request Sep 19, 2024
* handle corrupt saved searches

* small adjusments

---------

Co-authored-by: Cédric Anne <cedric.anne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants