-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop old debug globals and configs #16448
Conversation
cconard96
commented
Jan 27, 2024
Q | A |
---|---|
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | - |
249abac
to
dfd235b
Compare
dfd235b
to
bde31e0
Compare
I simplified a bit the code by computing durations without using the Profiler. There is no need to add complexity to the Profiler usage to just make a |
The ability to use the profiler as a regular timer should stay I think. There is at least one specific use case where it is better than manually computing |
The problem here was that the Profiler was used outside the debug mode, and it was necessary to introduce some logic to bypass existing limitations, eg the /**
* @param bool $force_start If true, the section will be started even if the user is not in debug mode.
* This is useful if the profiler is going to be used to simply time a section of code and
* the result will be used in the application.`
*/ I am not against giving the ability to get the execution time of a given section if it is easy to use for the developper and does not introduce too much complexity. |