Add missing inputs for rules using ticket validation criteria

[RomainLvr]

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

• It fixes !35677
• Here is a brief description of what this PR does

We create business rules for tickets, if we create a rule using only one criterion which is 'validation' it works, otherwise if we add another criterion in addition to 'validation' the rule never passes.

The problem comes from the fact that when the rule engine is run, the main item is CommonITILValidation, so the inputs to be processed come from this object, which does not contain the ticket fields. So you have to go and find the missing fields you need

Screenshots (if appropriate):

Work :

Dont work :

[stonebuzz]

Suggested change

	'id' => $this->fields[static::$items_id],
	'global_validation' => self::computeValidationStatus($item),
	'_from_itilvalidation' => true,
	'itemtype' => static::$itemtype
	];
	'id' => $this->fields[static::$items_id],
	'global_validation' => self::computeValidationStatus($item),
	'_from_itilvalidation' => true,
	] + $item->fields;

[stonebuzz]

I wonder if we shouldn't simply pass the fields (from related item) in $input

@cedric-anne what do you think?

[Rom1-B]

$item is a Ticket or a Change. If we update it with all its fields, isn't there a risk of triggering other rules?

[stonebuzz]

yes, that's why I want cedric's opinion, because it may give rise to a PR on main (and therefore feature request).